Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate final versions of Source files #252

Merged
merged 8 commits into from
Dec 6, 2022
Merged

Migrate final versions of Source files #252

merged 8 commits into from
Dec 6, 2022

Conversation

tjsilver
Copy link
Contributor

@tjsilver tjsilver commented Dec 6, 2022

What are you changing?

  • Some files have changed since we first copied them in from the Source repo. This PR brings over any changes so that the repos are up-to-date.

Why?

  • We can then archive the original Source folder and publish Source packages to NPM from the monorepo.

@tjsilver tjsilver requested a review from a team as a code owner December 6, 2022 14:15
@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 087c344

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Dec 6, 2022
@tjsilver @sndrs
@ob6160 @joecowton1
update Source package.jsons
48f823a 
Co-authored-by: Alex Sanders <alex@sndrs.dev>
Co-authored-by: Oliver Barnwell <ob6160@users.noreply.github.com>
Co-authored-by: Joe Cowton <77005274+joecowton1@users.noreply.github.com>
sndrs
sndrs approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@sndrs sndrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!!!

@tjsilver tjsilver enabled auto-merge (squash) December 6, 2022 15:58
@sndrs sndrs disabled auto-merge December 6, 2022 15:59
@tjsilver tjsilver merged commit 111944e into main Dec 6, 2022
@tjsilver tjsilver deleted the ts-ob/source-migration-final branch December 6, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sndrs sndrs sndrs approved these changes

Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjsilver @sndrs